RFR: 8073139 PPC64: User-visible arch directory and os.arch value on ppc64le cause issues with Java tooling

Andrew Hughes gnu.andrew at redhat.com
Wed Dec 2 21:38:15 UTC 2015


> The new revision does that:
> http://cr.openjdk.java.net/~asmundak/8073139/hotspot/webrev.03
> http://cr.openjdk.java.net/~asmundak/8073139/jdk/webrev.03
> http://cr.openjdk.java.net/~asmundak/8073139/root/webrev.03/

This has grown a lot from my version.

The main change seems to be in having to handle a ppc64le define
in numerous places, which seems unnecessary as ppc64 is present there.
The version I'm looking at that we used in 8 deliberately avoids this
by forcing ARCH back to ppc64 on ppc64le. Was there a reason not to do that?

The only case where ppc64le is different to ppc64, the ABI is used:

-#if defined(__ia64) || defined(__powerpc__)
+#if defined(__ia64) || (defined(__powerpc__) && !defined(ABI_ELFv2))

Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07

More information about the hotspot-dev mailing list