RFR 8144534: Refactor templateInterpreter and templateInterpreterGenerator functions

Coleen Phillimore coleen.phillimore at oracle.com
Thu Dec 3 01:58:25 UTC 2015

Summary: merged templateInterpreter_x86_32/64 into 
templateInterpreterGenerator_x86.cpp (some 32/64 functions remain for 
the hand coded crc functions).

open webrev at http://cr.openjdk.java.net/~coleenp/8144534.01/
bug link https://bugs.openjdk.java.net/browse/JDK-8144534

I tried to make this reviewable by hg renaming files.   I basically 
renamed templateInterpreter_ppc.cpp and removed the AbstractInterpreter 
functions and put them back into templateInterpreter_ppc.cpp.  I didn't 
really delete 4000 lines of code, more like 1500.

Also, can someone with the PPC and AARCH port look at and test out these 
changes? I tried to reduce the #includes in the new 
templateInterpreter_ppc/aarch64.cpp files which worked for sparc.

Tested with JPRT on all platforms, also ran jtreg and 
collocated/non-collocated tonga tests for linux x64 and i386 since 
that's were the real changes are.

See the bug for more details and my partial vision of how these 
functions will be reorganized when I remove the broken c++ interpreter.

Also tested that Zero still builds.


More information about the hotspot-dev mailing list