Request for Review (s) - 8133023: ParallelGCThreads is not calculated correctly

Jon Masamitsu jon.masamitsu at
Fri Dec 4 16:39:50 UTC 2015

Here's a new version of the fix (simpler thanks to a suggestion
from Kim).

In the above webrev vm_version_x86.hpp appears but has no changes.
There were changes to it in the previous version (04) but were undone in
this latest version and may be why it appears in the webrev.

The delta webrev is

It has a white-space change in vm_version_sparc.hpp  which
does not appear in the diffs.



On 12/2/2015 9:46 AM, Jon Masamitsu wrote:
> On 11/30/2015 11:47 AM, Kim Barrett wrote:
>> On Nov 30, 2015, at 12:20 PM, Jon Masamitsu 
>> <jon.masamitsu at> wrote:
>>>> src/share/vm/runtime/os.cpp
>>>>   319   VM_Version::vm_init_before_ergo();
>>>> This call is in generic code, but only two definitions have been
>>>> provided, for sparc and x86.  Missing are aarch64, ppc, and zero.
>>> Add vm_init_before_ergo() for those even though JPRT does not
>>> build them? I don't need to be convinced to do it.  Just
>>> encouraged.  Say "do it" and I'll do it.
>> I think you should do it, rather than knowingly breaking the build 
>> for those targets when the needed code is so trivial.
> Here's the webrev for the delta for review comments to this point.
> Webrev for complete patch is here.
> Jon

More information about the hotspot-dev mailing list