Request for Review (s) - 8133023: ParallelGCThreads is not calculated correctly

Thomas Schatzl thomas.schatzl at
Wed Dec 9 11:06:24 UTC 2015


On Tue, 2015-12-08 at 10:41 -0800, Jon Masamitsu wrote:
> Latest delta on the patch is at
> It contains a name change from the original patch
> vm_init_before_ergo() -> init_before_ergo() and some
> additional comments.
> Full patch is at

  75   static void init_before_ergo(void) {}

It's a bit odd to have an explicit void parameter list for this method.
While it is completely legal, for uniformity I would like to prefer that

Other than that see the nits from Kim, which were already fixed.

I do not need to see the change again.


More information about the hotspot-dev mailing list