RFR (M): 8145435: [JVMCI] some tests on Windows fail with: assert(!thread->is_Java_thread()) failed: must not be java thread
coleen.phillimore at oracle.com
Thu Dec 17 18:02:33 UTC 2015
This looks like a good cleanup.
On 12/17/15 12:46 PM, Christian Thalinger wrote:
>> On Dec 17, 2015, at 3:56 AM, Doug Simon <doug.simon at oracle.com> wrote:
>>> On 17 Dec 2015, at 08:20, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
>>>>>> I feel like there was a reason we weren’t using java_lang_Throwable::print_stack_trace but it looks like it handles the causes properly which is the only reason I could think of. Maybe Doug knows?
>>>>> There are two issues with java_lang_Throwable::print_stack_trace:
>>>>> 1. It doesn’t print the exception message, just the stack.
>>>> I’m printing the message separately:
>>>> java_lang_Throwable::print(exception, tty);
>>>> java_lang_Throwable::print_stack_trace(exception(), tty);
>>> There are already 3 other copies of this idiom. Throwable should probably have a single method for this. Or maybe print_stack_trace itself should do this?
>>> That would better parallel Throwable.printStackTrace().
>> Makes sense to me!
> It does. Here it goes:
> I’ve made java_lang_Throwable::print_stack_trace to take a Handle instead of an oop and removed the unneeded copy of java_lang_Throwable::print.
More information about the hotspot-dev