8074457: Remove the non-Zero CPP Interpreter

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Fri Dec 18 15:36:37 UTC 2015

Hi Coleen, 

I had a look at the shared and ppc files.  I also tested it on ppc, works

Some smaller things:
+ #if defined(TARGET_ARCH_ppc) || defined(TARGET_ARCH_sparc)
I's more common to use 
#if defined(PPC) || defined(AARCH64)

Maybe you want to clean up the #includes at the bottom as 
you do in the other files?

#ifdef TARGET_ARCH_zero  --> #ifdef ZERO
#ifdef TARGET_ARCH_ppc --> #ifdef PPC
... there are more of these.

I think the ppc method math_entry_available() can just be 'inlined'
at its callsite, so that the platform special case goes away.

I would just add the ppc parameters with default values to the existing definition
of lock_method().
unlock_method(): I would place this near lock_method().
Here also I would add the parameters to the existing function with default

Best regards,

> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
> Behalf Of Coleen Phillimore
> Sent: Freitag, 18. Dezember 2015 14:49
> To: hotspot-dev developers <hotspot-dev at openjdk.java.net>
> Subject: RFR: 8074457: Remove the non-Zero CPP Interpreter
> Summary: Remove cppInterpreter assembly files and reorganize
> InterpreterGenerator includes
> This change is mostly removal and removing the InterpreterGenerator
> class and making class Interpreter a typedef.  I removed conditional
> includes from interpreter header files in favor of small sections with
> ifdefs.   Many interpreter functions are still in the wrong cpp files
> but I want to leave that for a follow on, to not overwhelm reviewers.
> This is Large but not difficult to review.  There is also more purging
> that can be done with Zero, but I also want to leave that as a follow on
> RFE.
> This has been tested with RBT (most of runtime tests on x86 and sparc),
> JPRT and builds zero with debug/fastdebug and product.
> There are changes and deletions to ppc and aarch64.   Please let me know
> if you want to test with this patch or leave for follow on fixes.
> open webrev at http://cr.openjdk.java.net/~coleenp/8074457/
> bug link https://bugs.openjdk.java.net/browse/JDK-8074457
> Thanks,
> Coleen

More information about the hotspot-dev mailing list