RFR (s) : 8145740: Visual Studio pragmas should be guarded by #ifdef _MSC_VER

Langer, Christoph christoph.langer at sap.com
Mon Dec 21 22:17:31 UTC 2015

Hi Matthias,

to me your change looks good. However, I'm no reviewer so you'll need sponsorship from someone else.

Can someone please sponsor this? Should it maybe be posted in another list for better visibility?

Best regards

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Baesken, Matthias
Sent: Freitag, 18. Dezember 2015 14:30
To: hotspot-dev at openjdk.java.net
Cc: Simonis, Volker <volker.simonis at sap.com>
Subject: RFR (s) : 8145740: Visual Studio pragmas should be guarded by #ifdef _MSC_VER

   can you please review and sponsor this change :


Some details :

     while  Visual Studio pragmas in shared code are usually guarded with  _MSC_VER in the hotspot codebase
( see for example   taskqueue.hpp or  compressedStream.cpp ) , the guarding is missing in   src/share/vm/utilities/growableArray.hpp  ,
which is not really a "good thing"  for other compilers .

Thanks and regards, Matthias

More information about the hotspot-dev mailing list