RFR: 8074457: Remove the non-Zero CPP Interpreter

Bertrand Delsart bertrand.delsart at oracle.com
Tue Dec 22 13:48:04 UTC 2015

Hi Coleen,

Overall looks good. Thanks for the cleanup.

A few minor issues. No showstoppers. Feel free to ignore them or handle 
them later.

First issue in 
src/share/vm/interpreter/templateInterpreterGenerator.hpp, for instance 
for these lines :

  #ifdef TARGET_ARCH_aarch64
- # include "templateInterpreterGenerator_aarch64.hpp"
- #endif
+ void bang_stack_shadow_pages(bool native_call);
+ void generate_transcendental_entry(AbstractInterpreter::MethodKind 
kind, int fpargs);
+ #endif // TARGET_ARCH_aarch64

Is there a reason to remove a CPU dependent file, which could be 
customized by any porting group, and instead directly add port-dependent 
methods in a shared file ?

Similar problem for AbstractInterpreter::expr_offset_in_bytes, which was 
defined in CPU dependent files but is now defined in 
abstractInterpreter.hpp, requiring a PPC and SPARC ifdef. Should we 
instead define new abstractInterpreter_<cpu>.hpp files, including the 
CPU specific part that was in interpreter_<cpu>.hpp ?



On 18/12/2015 14:49, Coleen Phillimore wrote:
> Summary: Remove cppInterpreter assembly files and reorganize
> InterpreterGenerator includes
> This change is mostly removal and removing the InterpreterGenerator
> class and making class Interpreter a typedef.  I removed conditional
> includes from interpreter header files in favor of small sections with
> ifdefs.   Many interpreter functions are still in the wrong cpp files
> but I want to leave that for a follow on, to not overwhelm reviewers.
> This is Large but not difficult to review.  There is also more purging
> that can be done with Zero, but I also want to leave that as a follow on
> RFE.
> This has been tested with RBT (most of runtime tests on x86 and sparc),
> JPRT and builds zero with debug/fastdebug and product.
> There are changes and deletions to ppc and aarch64.   Please let me know
> if you want to test with this patch or leave for follow on fixes.
> open webrev at http://cr.openjdk.java.net/~coleenp/8074457/
> bug link https://bugs.openjdk.java.net/browse/JDK-8074457
> Thanks,
> Coleen

Bertrand Delsart,                     Grenoble Engineering Center
Oracle,         180 av. de l'Europe,          ZIRST de Montbonnot
38330 Montbonnot Saint Martin,                             FRANCE
bertrand.delsart at oracle.com             Phone : +33 4 76 18 81 23

NOTICE: This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or
distribution is prohibited. If you are not the intended recipient,
please contact the sender by reply email and destroy all copies of
the original message.

More information about the hotspot-dev mailing list