RFR (S): JDK-8066599: Add methods to check VM mode to c.o.j.t.Platform

Filipp Zhinkin filipp.zhinkin at gmail.com
Fri Dec 25 07:41:29 UTC 2015

Hi Igor,

thanks for looking at this change.

On Thu, Dec 24, 2015 at 9:24 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> Hi Filipp,
> could you please move TestMutuallyExclusivePlatformPredicates and TestPlatformIsTieredSupported from hotspot/testlibrary_tests/ to test/lib-test and update it according to your changes? please note that we started to use packages in our tests.

Sure, I'll move it.

Do I need to pass any specific options to jtreg to make '@library
/test/lib' work?
At the moment jtreg can't locate it unless I specify

Does it make sense to also move ClassFileInstaller to jdk.test.lib?


> otherwise looks good to me.
> Thanks,
> — Igor
>> On Dec 22, 2015, at 10:36 AM, Filipp Zhinkin <filipp.zhinkin at gmail.com> wrote:
>> Hi all,
>> please review a small change that adds VM mode checking methods to
>> jdk.test.lib.Platform.
>> I didn't touch Platform class from hotspot/test/testlibrary, because
>> it is already deprecated and at some point of time all hs tests will
>> be updated to use j.t.l.Platform instead.
>> Update of hs tests that use own logic to check VM mode is tracked by
>> JDK-8145848 [1].
>> Webrev: http://cr.openjdk.java.net/~fzhinkin/8066599/webrev.00/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8066599
>> Testing: on local machine with different VM modes.
>> Regards,
>> Filipp.
>> [1] https://bugs.openjdk.java.net/browse/JDK-8145848

More information about the hotspot-dev mailing list