RFR: 8073389: Remove the include of resourceArea.hpp from classFileParser.hpp
stefan.karlsson at oracle.com
Wed Feb 18 09:46:32 UTC 2015
I've verified that assert_property still works by artificially inducing
errors into the class file parser:
# fatal error: Invalid field attribute index 5 in class file
# fatal error: Invalid ConstantValue field attribute length 2 in class
On 2015-02-18 10:35, Stefan Karlsson wrote:
> Please review this patch to get rid of the inclusion of
> resourceArea.hpp from classFileParser.hpp.
> From the RFE:
> The inclusion of resourceArea.hpp in classFileParser.hpp is causing
> cyclic dependencies when I'm changing unrelated code. The main reason
> for this is that a lot of implementation is put inside the
> resourceArea.hpp file instead of a .cpp file.
> I've opted to go the easy route now and get rid of the the
> resourceArea.hpp dependency from classFileParser.hpp, but eventually
> it would be good to fix that file.
> This patch has to add explicit includes of resourceArea.hpp to other
> .hpp files, that used to get their include from classFileParser.hpp. I
> could have gotten rid of those dependencies as well, but I chose to
> not do that for this patch.
More information about the hotspot-dev