RFR: 8073389: Remove the include of resourceArea.hpp from classFileParser.hpp

David Holmes david.holmes at oracle.com
Wed Feb 18 11:36:17 UTC 2015

On 18/02/2015 7:35 PM, Stefan Karlsson wrote:
> Hi,
> Please review this patch to get rid of the inclusion of resourceArea.hpp
> from classFileParser.hpp.
>  From the RFE:
> The inclusion of resourceArea.hpp in classFileParser.hpp is causing
> cyclic dependencies when I'm changing unrelated code. The main reason
> for this is that a lot of implementation is put inside the
> resourceArea.hpp file instead of a .cpp file.

I must be missing something here - the implementation in the .hpp file 
is because all of the functions are implicitly inline. No guarantee they 
will be inlined of course but at least in product mode many of them 
should be. So assuming this is a good thing and we want to keep that for 
performance then the fix would be to introduce a .inline.hpp file, not 
to move stuff to a .cpp file.

> I've opted to go the easy route now and get rid of the the
> resourceArea.hpp dependency from classFileParser.hpp, but eventually it
> would be good to fix that file.
> This patch has to add explicit includes of resourceArea.hpp to other
> .hpp files, that used to get their include from classFileParser.hpp. I
> could have gotten rid of those dependencies as well, but I chose to not
> do that for this patch.
> http://cr.openjdk.java.net/~stefank/8073389/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8073389

What was classFileParser.hpp using from resourceArea.hpp ?

How does the change to src/share/vm/services/runtimeService.cpp fit in ??

Seems okay - the proof is in the building as always. Need to check with 
and without precompiled headers. And copyright dates need updating.


> Thanks,
> StefanK

More information about the hotspot-dev mailing list