RFR: 8073108: GHASH Intrinsics
anthony.scarpino at oracle.com
Fri Feb 20 05:22:50 UTC 2015
On Feb 19, 2015, at 5:36 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> JDK changes review.
> All exceptions should print invalid value as you did for state and subkeyH checks. It would greatly help debugging.
> Please, split first check into 3 separate checks and print invalid value to know which condition failed.
> Missing space after 'length': "invalid length”+subkeyH.length
Ok.. I’ll make those changes
> Hotspot review.
> Everything seems fine. Thank you for fixing the test.
> What do you mean "Changed GHASHIntrinsics"? Don't pass intrinsic_id or something else?
I combined the two change into one bullet point. Your comment about merging has_vis3() and UseVIS into one if() in vm_version_sparc.cpp and the addition code to prevent other platforms from using the flag. Both involved GHASHIntrinsics.
> On 2/19/15 4:52 PM, Anthony Scarpino wrote:
>> I've updated the webrevs. I believe I've added everyone's comments.
>> - Changed GHASHIntrinsics and disabled for non-supported platforms
>> - removing WIN64 ifdef in 32bit x86
>> - fixed hotspot test so it can use compareArray()
>> - modified the range checking
>> - fixed processBlocks comment
More information about the hotspot-dev