RFR: 7143664: Clean up OrderAccess implementations and usage
kim.barrett at oracle.com
Sun Feb 22 06:44:48 UTC 2015
On Feb 21, 2015, at 11:51 PM, David Holmes <david.holmes at oracle.com> wrote:
> My 2c as the sponsor here. If we get into matters of style then we can debate endlessly, so lets not do that :) (or at least lets not have that hold up getting this pushed through - we can debate and refine later if needed). As far as macros are concerned I'd need to see a concrete example of what is proposed to evaluate its utility with regard to understandability or maintainability - but as a template novice I find the current structure quite readable and understandable.
Since I was in the process of drafting a message suggesting essentially this, well, I agree.
I think this change set is a significant improvement. While I think there are some issues, as well as some things that I would have done differently, I haven’t found anything that I think should prevent acceptance. We can discuss further issues and stylistic questions as followups.
More information about the hotspot-dev