RFR: 8068396: Rename assert() to vmassert()
erik.helin at oracle.com
Mon Jan 12 09:02:46 UTC 2015
On 2015-01-12, David Holmes wrote:
> On 10/01/2015 4:11 AM, Kim Barrett wrote:
> >On Jan 8, 2015, at 8:05 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> >>On Jan 8, 2015, at 7:43 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
> >>>My prior email asked if you could test this change by changing an assert to vmassert. The assert in debug.cpp test_error_handler to vmassert would be a good one to test this change.
> >>Ah, now I understand what you were asking for. OK, I’ll do that and post a new webrev later this evening.
> >New webrev: http://cr.openjdk.java.net/~kbarrett/8068396/webrev.03/
> >Incremental webrev: http://cr.openjdk.java.net/~kbarrett/8068396/webrev.03.incr/
> Webrev looks fine but for some reason you patch file did not update:
> still seems to be version 1.
I suspect that Kim is using `webrev -r` to create the webrev, this is
known to produce broken patch files:
> >As before, only the full webrev contains copyright updates.
> >I ran jtreg locally and verified test/runtime/6888954/vmerrors.sh ran successfully.
More information about the hotspot-dev