RFR: 8068396: Rename assert() to vmassert()
erik.helin at oracle.com
Tue Jan 13 08:01:40 UTC 2015
On 2015-01-12, Kim Barrett wrote:
> On Jan 12, 2015, at 4:02 AM, Erik Helin <erik.helin at oracle.com> wrote:
> > On 2015-01-12, David Holmes wrote:
> >> On 10/01/2015 4:11 AM, Kim Barrett wrote:
> >>> New webrev: http://cr.openjdk.java.net/~kbarrett/8068396/webrev.03/
> >>> Incremental webrev: http://cr.openjdk.java.net/~kbarrett/8068396/webrev.03.incr/
> >> Webrev looks fine but for some reason you patch file did not update:
> >> http://cr.openjdk.java.net/~kbarrett/8068396/webrev.03/hotspot.changeset
> >> still seems to be version 1.
> > I suspect that Kim is using `webrev -r` to create the webrev, this is
> > known to produce broken patch files:
> > https://bugs.openjdk.java.net/browse/CODETOOLS-7901115
> Using “webrev -r” is indeed what I’m doing. I was unaware of that bug.
> Any suggestions for what else I should do? I’m using hg mq’s to manage the changes locally.
> That seems to require using -r when creating the webrev; “-r qparent” for the full webrev, and
> “-r <prev-mq-patch>” for the incremental webrev.
This is the way I manage my patches as well. Unfortunately, I don't know
of any way to work around this bug in webrev :(
Anyone here with ksh and hg knowledge that might be able to take a look
at the bug?
More information about the hotspot-dev