RFR(L): 8130654: ppc: implement MultiplyToLen intrinsic

Volker Simonis volker.simonis at gmail.com
Fri Jul 10 14:48:16 UTC 2015

Hi Goetz,

the change looks good.

I have just a few minor remarks:

- please update the copyright year

- you removed UseNewFastLockPPC64 - can you please also remove the
last occurrence in  ppc.ad

- once you already declared the various temp registers, maybe you can
also use these temp names for spilling? This could avoid potential
problems if somebody changes one of the temp registers. And you could
also use R1_SP instead of R1 to make it more clear that R1 is the SP.


On Tue, Jul 7, 2015 at 10:47 AM, Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> Hi,
> Peter ported the multiplyToLen intrinsic for ppc.
> Please review this change
> http://cr.openjdk.java.net/~goetz/webrevs/8130654-mulToLen/webrev.01/
> We tested this with jck, jtreg and our benchmarks on aix, ppc64 and ppc64le.
> Best regards,
>   Goetz.

More information about the hotspot-dev mailing list