RFR: JDK-8130527: serviceability tests fails with Can't attach to process

David Holmes david.holmes at oracle.com
Thu Jul 30 04:56:48 UTC 2015

On 30/07/2015 12:29 AM, Alexander Kulyakhtin wrote:
> Hi,
> Could you, please, review the following small test-only fix:
> CR: JDK-8130527 "Serviceability tests fails with Can't attach to process." (the CR was submitted as confidential for other reasons, all changes are in the public domain)
> Webrev: http://cr.openjdk.java.net/~akulyakh/8130527/index.html
> Before the fix we were excluding the tests from execution based on the contents of a certain Linux file, which we read into a single String for analysis.
> Due to a regression JDK-8132539 the API we used for reading the file into a string is broken.
> We are changing the reading method to use an older API.

Looks okay. Please add a space after "if":

if(!Files.exists(filePath)) return null;


> Best regards,
> Alexander

More information about the hotspot-dev mailing list