RFR (M): 8112746: Followup to JDK-8059557 (JEP 245: Validate JVM Command-Line Flag Arguments)

gerard ziemski gerard.ziemski at oracle.com
Fri Jul 31 18:04:04 UTC 2015

Please review this webrev 2 of the follow-up fixes including:

- Adding DBL_MAX (requested by Kim Barrett)

- Passing values by value, not pointer, to constraint functions. It was thought originally that me way want to “fix” the values, but it was decided to be out of scope for the JEP. (requested by Coleen)

- Add print_error_as_needed() utility function to range/constraint code to improve code robustness (requested by Coleen)

- Remove debug code (requested by Kim Barrett)

- Implement Flag::flag_error_str in .cpp file (requested by Kim Barrett)

- Only check constraint if range passes (requested by Kim Barrett)

- Merged with Sangheon Kim fix for "Add additional validation after heap creation” (JDK-8130459)

This webrev passes "JPRT -testset hotspot” and “RBT vm.quick testlist”


    JEP 245: https://bugs.openjdk.java.net/browse/JDK-8122937

More information about the hotspot-dev mailing list