RFR(XS): 8085975: Fix warning "converting to jlong from double" of gcc 4.1.2 after 8079561
goetz.lindenmaier at sap.com
Tue Jun 9 06:22:25 UTC 2015
thanks for the review and sponsoring!
From: Erik Helin [mailto:erik.helin at oracle.com]
Sent: Montag, 8. Juni 2015 18:11
To: Lindenmaier, Goetz
Cc: HotSpot Developers
Subject: Re: RFR(XS): 8085975: Fix warning "converting to jlong from double" of gcc 4.1.2 after 8079561
Looks good, Reviewed. I can sponsor the patch.
On 2015-06-08, Lindenmaier, Goetz wrote:
> Since 8079561 our build with gcc 4.1.2 fails because of "timer.cpp:62: warning: converting to jlong from double".
> This change adds casts to fix this.
> Please review this change. I please need a sponsor.
> This warning is enabled by default in gcc 4.1.2 and can only be turned off by turning off all warnings. We would like to avoid turning off all warnings, though. But because of Werror this breaks the gcc 4.1.2 build.
> The warning can be triggered by setting -Wconversion in gcc 4.8. This triggers a lot of undesired warnings, and thus is off since it got the current semantics in gcc 4.3. In gcc 4.9, the warning can be triggered with less extra noise by -Wfloat-conversion, which seems desireable to be turned on to me once that compiler is used.
> All similar code locations are fixed as required by 4.1.2 (e.g., see services/management.cpp:2170 return (jlong)(((double)ticks / (double)os::elapsed_frequency())), therefore I would like to fix this by adding casts.
> Best regards,
More information about the hotspot-dev