RFR(XXS): 8086073: Fix PrintStubCode for empty StubCodeGenerator.
lois.foltan at oracle.com
Wed Jun 10 20:07:30 UTC 2015
On 6/10/2015 11:01 AM, Lindenmaier, Goetz wrote:
> Vladimir, Lois, thanks for the review!
> Could one of you please sponsor this? Iadded the Reviewed-by comment,
> so you can take the change as-is.
Sure, I would be happy to. I will let you know when it has been committed.
> Thanks and best regards,
> -----Original Message-----
> From: Lois Foltan [mailto:lois.foltan at oracle.com]
> Sent: Mittwoch, 10. Juni 2015 13:14
> To: Lindenmaier, Goetz
> Cc: HotSpot Developers
> Subject: Re: RFR(XXS): 8086073: Fix PrintStubCode for empty StubCodeGenerator.
> Looks good.
> On 6/10/2015 2:46 AM, Lindenmaier, Goetz wrote:
>> PrintStubCode runs into an assertion if a StubCodeGenerator that never generated
>> a stub is deleted. This happens for ICacheStubGenerator on ppc, as we implement
>> the flushing with inline assembly and don't generate a stub.
>> The fix is to check for an empty list in the assertion.
>> Please review and sponsor this tiny fix.
>> Best regards and thanks,
More information about the hotspot-dev