RFR(XS) 8098552: 8079792 breaks Zero builds without precompiled headers.
sgehwolf at redhat.com
Mon Jun 15 13:00:24 UTC 2015
On Mon, 2015-06-15 at 14:18 +0200, Stefan Johansson wrote:
> Thanks Erik,
> Severin, can you provide an updated patch generated by 'hg export'. Once
> I get that, I'll push it right away. No need to wait 24h for such a
> trivial fix.
Thanks, Stefan and Erik. I've sent the updated hg exported patch to
Stefan for pushing.
> On 2015-06-15 14:16, Erik Helin wrote:
> > On 2015-06-15, Stefan Johansson wrote:
> >> Hi Severin,
> >> Fix is correct, but we try to keep the includes sorted so please change it
> >> to be:
> >> #include "memory/allocation.hpp"
> >> +#include "memory/memRegion.hpp"
> >> #include "utilities/debug.hpp"
> >> I'm not a reviewer, but can sponsor this change and push it as soon as we
> >> get a Reviewer to look at it.
> > Pending the comment above by Stefan, the patch looks good. Reviewed.
> > Thanks,
> > Erik
> >> Thanks,
> >> Stefan
> >> On 2015-06-15 11:58, Severin Gehwolf wrote:
> >>> Hi,
> >>> Could somebody please review and sponsor this trivial fix? The issue is
> >>> that the Zero build fails with precompiled headers turned off (other
> >>> builds probably too, but I haven't checked). The fix is to include
> >>> memRegion.hpp in g1/g1BiasedArray.hpp since it uses MemRegion.
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8098552
> >>> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8098552/webrev.01/
> >>> Thanks,
> >>> Severin
More information about the hotspot-dev