RFR (XXS): 8129602: Incorrect GPL header causes RE script to create wrong output

Thomas Schatzl thomas.schatzl at oracle.com
Wed Jun 24 09:25:33 UTC 2015

Hi again,

On Wed, 2015-06-24 at 11:03 +0200, Thomas Schatzl wrote:
> Hi all,
>   I need reviews for a small set of fixes that removes superfluous
> commas after the year in the GPL header so that some release engineering
> script does not produce garbage.

Sorry, the description of the issue in the email is wrong. There are, in
- a few whitespace removals in some gpl headers

in addition to that, in jdk8,
- a few commas had to be *added*

I wrote the email first, and then during rechecking the problems I found
that actually most of them were about *adding* commas, not removing

Initially, I got a bit confused about the problem, because in jdk9 the
commas were all fixed (trying to apply the requested changes to jdk9
first - they are reported for 8u60), and thought that they need to be
removed because the CRs constantly talk about messed up commas after the
years. I.e. the bug reports all contain some copy&pasted text block that
is completely unrelated :)

That is actually not the case. I got confused by that.

> This CR fixes these issues for several files across the hotspot
> repository, bundling multiple similar problems. That's why this issue
> has been sent for review to hotspot-dev.
> CR (confidential, sorry):
> https://bugs.openjdk.java.net/browse/JDK-8129602
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8129602/webrev.hotspot/
> http://cr.openjdk.java.net/~tschatzl/8129602/webrev.hs-gc/ (for
> whitebox.cpp).
> Here is the corresponding 8u60 patch that differs in paths and adds a
> few more typos that have been fixed in 9.
> http://cr.openjdk.java.net/~tschatzl/8129602/webrev.8u60/

I removed some removal of two empty lines at the end of one of the GPL
headers that accidentally got through some last look at it. Thanks go to
StefanK for that.


More information about the hotspot-dev mailing list