RFR (XXS): 8129602: Incorrect GPL header causes RE script to create wrong output
coleen.phillimore at oracle.com
Wed Jun 24 11:16:32 UTC 2015
This looks good (in case you haven't already pushed it). I think you
fixed your removal of the extra blank lines in the final
patch. I'm sorry I didn't address all of these issues when I did the
one assigned to me. David pointed the other bugs out to me after I'd
started my JPRT job.
Now we know something will catch missing , at the end of copyright years.
On 6/24/15 5:58 AM, David Holmes wrote:
> Just saw your follow up mail so all is good.
> On 24/06/2015 7:56 PM, David Holmes wrote:
>> Hi Thomas,
>> On 24/06/2015 7:03 PM, Thomas Schatzl wrote:
>>> Hi all,
>>> I need reviews for a small set of fixes that removes superfluous
>>> commas after the year in the GPL header so that some release
>>> script does not produce garbage.
>> Actually add the missing commas where needed :)
>>> This CR fixes these issues for several files across the hotspot
>>> repository, bundling multiple similar problems. That's why this issue
>>> has been sent for review to hotspot-dev.
>>> CR (confidential, sorry):
>> You need to look at the patch to see the whitespace fix :)
>>> http://cr.openjdk.java.net/~tschatzl/8129602/webrev.hs-gc/ (for
>>> Here is the corresponding 8u60 patch that differs in paths and adds a
>>> few more typos that have been fixed in 9.
>> This all looks fine too. So the commas are already fixed in 9?
More information about the hotspot-dev