RFR(S): 8129757: ppc/aarch: Fix passing thread to runtime after "8073165: Contended Locking fast exit bucket."

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Jun 24 15:57:02 UTC 2015

On 6/24/15 1:40 AM, Lindenmaier, Goetz wrote:
> Hi,
> Change 8073165 added a new argument to complete_monitor_unlocking_C(): the current thread. Moving this value into the argument registers before the runtime call issued in the native wrapper was missing on ppc and aarch.
> Please review this change:
> http://cr.openjdk.java.net/~goetz/webrevs/8129757-unlock/webrev-01/

     L2132     rt_call(masm, CAST_FROM_FN_PTR(address, 
SharedRuntime::complete_monitor_unlocking_C), 3, 0, 1);

         nit: It would nice if there was comment like above L2132:

         // Arguments are (oop obj, BasicLock* lock, JavaThread* thread).

     No comments.

Thumbs up.


> Edward Nevill already had a look at the aarch changes and tested them.
> Best regards,
>    Goetz.

More information about the hotspot-dev mailing list