RFR(XXL): 8079792: GC directory structure cleanup
per.liden at oracle.com
Wed May 13 08:44:40 UTC 2015
> On 12 May 2015, at 20:25, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
> On 5/12/15, 2:08 PM, Derek White wrote:
>> On 5/12/15 6:16 AM, Per Liden wrote:
>>> As previously mentioned , the GC team is doing a cleanup of the directory structure for the GC code. Here's the patch for that cleanup.
>>> First, a recap of the new directory structure:
>>> - A single "top-level" directory for GC code:
>>> - One sub-directory per GC:
>>> - A single directory for common/shared GC code:
>> Typo? I think you meant:
>> That's what the webrev looks like.
>> Looking forward to the simpler structure (luckily my fingers don't have the old structure memorized :-)
> My fingers had the old structure somewhat memorized since it never made mental sense to me, but even so, I'm very pleased to see this change!
I’m happy to hear that.
> I can't tell from the giant webrev, but did you reorganize the SA duplicated directory structure? It seems like some files moved but not all of them. If not with this change, can you do a follow-on an RFE to fix it also?
The GCs which had their own directory in the SA were moved/renamed according to the new structure. However, the SA had a slightly broken structure to begin with (like CMS-files live in the memory directory), and those are left as is at the moment. I plan to file a separate bug to fix that.
>> - Derek
More information about the hotspot-dev