RFR (S) 8140650: Method::is_accessor should cover getters and setters for all types
aleksey.shipilev at oracle.com
Thu Nov 5 16:53:55 UTC 2015
On 11/05/2015 07:46 PM, Vladimir Ivanov wrote:
> My idea was to warn Zero maintainers about a change which breaks their
> code and give them some time to react accordingly (provide missing
> functionality). After that just push the change. If Zero support is
> missing, then just file a bug.
> If there's an RFE filed and Zero maintainers promise to fix it in a
> prompt manner, I'm fine with what you proposed.
Yeah, that's the plan.
> Also, I had an idea: why don't you move is_simple_accessor() from Method
> to some Zero-specific location? I don't see any value in keeping it in
That's an interesting trick, but I think it will cause more harm: shared
interpreter.cpp would have to know about that Zero-specific method, or
otherwise intercept "too wide" accessor shape and narrow it down before
it reaches Zero. Therefore, I believe is_simple_accessor is the lesser evil.
More information about the hotspot-dev