RFR (S) 8140650: Method::is_accessor should cover getters and setters for all types
aleksey.shipilev at oracle.com
Thu Nov 5 17:24:02 UTC 2015
On 11/05/2015 07:59 PM, Vladimir Ivanov wrote:
>>> If there's an RFE filed and Zero maintainers promise to fix it in a
>>> prompt manner, I'm fine with what you proposed.
>> Yeah, that's the plan.
>>> Also, I had an idea: why don't you move is_simple_accessor() from Method
>>> to some Zero-specific location? I don't see any value in keeping it in
>> That's an interesting trick, but I think it will cause more harm: shared
>> interpreter.cpp would have to know about that Zero-specific method, or
>> otherwise intercept "too wide" accessor shape and narrow it down before
>> it reaches Zero. Therefore, I believe is_simple_accessor is the lesser
> Ok. Looks good then.
Thanks for taking time to review, Vladimir! I'll count that as the
review from the compiler side.
I think we still need a review from the runtime side. Folks? For the
record, we are discussing this change:
The patch passes JPRT, RBT (hotspot_all), and the new regression test.
More information about the hotspot-dev