RFR (XS): JDK-8141548 Hotspot Windows build should respect WARNINGS_AS_ERRORS

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Nov 6 10:49:33 UTC 2015

On 2015-11-06 08:36, David Holmes wrote:
> Just realized as per other RFR hotspot uses WARNINGS_ARE_ERRORS not AS
Yes and no. That value is only used in the unix make files, not in the 
Windows nmake. In there, there have been no support for disabling 
warnings as errors at all.

I actually started out trying to use a similar construct but nmake is 
horribly limited and I couldn't figure out a way to skip error 
processing by setting the value to empty and pass that along, the way it 
works for the unix make files. :-(

So instead this fix reads the value build-infra value, as set in 
spec.gmk. If the spec file is not present, then neither is this 
variable, and the behavior will be the same as without the fix (i.e. all 
warnings are errors). I don't intend to mess around any more with the 
old nmake files. If this is not acceptable, I'll drop it until the new 
hotspot build is done.


More information about the hotspot-dev mailing list