RFR (s) 8141570: Fix Zero interpreter build for --disable-precompiled-headers
sgehwolf at redhat.com
Mon Nov 9 12:51:24 UTC 2015
On Fri, 2015-11-06 at 11:47 -0500, Kim Barrett wrote:
> On Nov 5, 2015, at 8:33 PM, Coleen Phillimore <coleen.phillimore at orac
> le.com> wrote:
> > With the RedHat compiler that I'm using g++ (GCC) 4.8.2 20140120
> > (Red Hat 4.8.2-16)
> > these additional includes are needed to compile without precompiled
> > headers.
> > open webrev at http://cr.openjdk.java.net/~coleenp/8141570.01/
> > bug link https://bugs.openjdk.java.net/browse/JDK-8141570
> > I'm not sure why allocation.inline.hpp is needed unless the virtual
> > destructor in src/share/vm/gc/shared/plab.hpp PLABStats implicitly
> > calls delete.
> > Tested with compiles of Zero plus plain linux
> > debug/fastdebug/product.
> > Thanks,
> > Coleen
> 29 #include "memory/allocation.inline.hpp"
> 30 #include "runtime/atomic.inline.hpp"
> xxx.inline.hpp files are not supposed to be included by xxx.hpp
> The need for atomic.inline.hpp seems clear, and would seem to
> constitute a bug in
> g1EvacStats.hpp - there should be a g1EvacStats.inline.hpp file.
> I really don’t understand why allocation.inline.hpp is needed here at
FWIW, the below hunk seems to be all that's necessary in order to fix
the --disable-precompiled-headers Zero build for me:
diff --git a/src/share/vm/runtime/java.cpp b/src/share/vm/runtime/java.cpp
@@ -49,6 +49,7 @@
It does not seem the other change is required. Tested with fastdebug
build of Zero with --disable-precompiled-headers that failed to build
without and built fine with the fix.
Coleen, do you have details about the failure which gets supposedly
fixed by the other hunk?
Also the original build failure this patch is supposed to fix now got
picked up by our builders too:
More information about the hotspot-dev