RFR: 8077571: ObjPtrQueue is poorly named
kim.barrett at oracle.com
Mon Nov 9 20:34:38 UTC 2015
On Nov 9, 2015, at 12:36 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> On Nov 7, 2015, at 10:58 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
>> On Nov 6, 2015, at 5:21 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>> On Nov 6, 2015, at 12:09 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>>> [Sending to hotspot-dev because this touches runtime and compiler
>>>> files too. I'm particularly looking for a compiler person for the
>>>> change to HotSpotVMConfig.java.]
>>> Yes, that change looks good.
>> Thanks! I wasn’t getting anywhere trying to figure out what might be impacted by that change.
> It’s really not that complicated. A HotSpotVMField annotation reads a property specified by “get” for a C++ field with the name “name” with the type “type”. In this case:
> + @HotSpotVMField(name = "JavaThread::_satb_mark_queue", type = "SATBMarkQueue", get = HotSpotVMField.Type.OFFSET) @Stable public int javaThreadSatbMarkQueueOffset;
> it is reading the offset of the field JavaThread::_satb_mark_queue. The type is only used for verification.
Thanks for the explanation. I only occasionally pretend to be a Java programmer, and haven’t studied up on annotations yet.
More information about the hotspot-dev