RFR (s) 8141570: Fix Zero interpreter build for --disable-precompiled-headers
david.holmes at oracle.com
Wed Nov 18 20:39:12 UTC 2015
On 18/11/2015 5:18 AM, Kim Barrett wrote:
> On Nov 16, 2015, at 8:36 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>> Sorry that was the wrong webrev:
>> open webrev at http://cr.openjdk.java.net/~coleenp/8141570.02/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8141570
> Code changes look good.
> Not surprisingly, I like the makefile changes, though after the discussion and Severin’s results I’d be
> tempted to remove any special -Wundef handling for llvm and wait for someone with a complaint to
> supply llvm version information.
The makefile changes seem unrelated to the actual bug report, but ok.
Minor nit: New include isn't in alphabetical order.
Otherwise all seems good.
More information about the hotspot-dev