RFR(S) 8134898: Small fixes found during JVMCI work

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Sep 3 16:20:31 UTC 2015

On 9/3/15 4:22 AM, David Holmes wrote:
> On 2/09/2015 9:59 AM, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/8134898/webrev/
>> https://bugs.openjdk.java.net/browse/JDK-8134898
>> During review of JVMCI changes we were asked to push not related small
>> changes separately.
>> Removed jre/ from jdk paths in makefiles since jdk9 does not have it
>> anymore.
> JDK9 also does not have rt.jar anymore so much of what is in  this area of make/Makefile seems unused and unworking.
>> Solaris vm.make and buildtree.make missed changes other unix platforms
>> have.
> make/solaris/makefiles/vm.make
> Does Shark even exist on Solaris? Has this been tested?

I don't know. I made this change for consistency of makefiles on all unix platforms.
Main change in the file was fix for Src_Files_EXCLUDE because exclusion of jvmci files did not work.


> Thanks,
> David
>> Fix type in doc.
>> Added -DCHECK_UNHANDLED_OOPS to debug build. I very strongly want to do
>> that.
>> It is the only incompatibility in memory layout between fastdebug and
>> debug VM. We maintained such compatibility for long time and it was
>> broken with 7195622 changes.
>> For AOT project it is very important to keep compatibility because we
>> use fastdebug VM for JAOTC tool to compile aot code and we want to be
>> able use debug VM to debug execution of aot code.
>> Note, using debug VM with JAOTC will take 5-10 times longer to compile.
>> Thanks,
>> Vladimir

More information about the hotspot-dev mailing list