RFR (s) 8135298: Fix zero builds for "unknown" architectures on linux.
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Thu Sep 17 08:50:29 UTC 2015
I'm not sure this code does what you think it does. At least when
building from the top-level makefile, ZERO_LIBARCH will always be set,
so the "unknown" case will not be reached.
Also, I'd like to hijacking this thread slightly, sorry about that. :)
When rewriting the Hotspot makefiles, I've been wondering if it would
not make more sense to consider "zero" to be a different architecture,
rather than a different "flavor" (like minimal1), as it is treated right
now. This patch seems to align with the treatment of zero as an
architecture. Just as an open question, do you think that would make sense?
On 2015-09-10 10:46, Severin Gehwolf wrote:
> On Thu, 2015-09-10 at 14:18 +1000, David Holmes wrote:
>> Thanks Coleen! Looks good.
>> On 10/09/2015 1:57 PM, Coleen Phillimore wrote:
>>> Summary: add zero architectures for default cases
>>> Reviewed-by: coleenp, dholmes
>>> Contributed-by: Matthias Klose <doko at ubuntu.com>
>>> Tested on linux zero and linux x64.
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8135298/
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8135298
> Thanks, Coleen, for getting this pushed!
More information about the hotspot-dev