[8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

Rob McKenna rob.mckenna at oracle.com
Wed Sep 30 13:40:25 UTC 2015



On 30/09/15 14:30, Magnus Ihse Bursie wrote:
> On 2015-09-30 14:43, Erik Joelsson wrote:
>> Hello,
>> Please approve and review this fix for 8u.
>> My last fix for this issue, JDK-8136691, was not enough. I made a
>> mistake while verifying the fix and the problem is still there.
>> There are more discrepancies between Solaris and the other platform
>> makefiles. The excludeSrc.gmk file is not included anywhere when
>> building on Solaris. The variable Src_Files_EXCLUDE is overwritten in
>> vm.make instead of appended to, so even when including excludeSrc.gmk,
>> it wasn't enough. The other platform specific buildtree.make files
>> also set INCLUDE_TRACE in the generated makefile.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8136980
>> Webrev: http://cr.openjdk.java.net/~erikj/8136980/webrev.hotspot.01/
>> /Erik
> Looks good to me.
> /Magnus

More information about the hotspot-dev mailing list