RFR (M) 8146410: Interpreter functions are declared and defined in the wrong files
coleen.phillimore at oracle.com
Tue Jan 5 18:17:07 UTC 2016
On 1/5/16 2:19 AM, Lindenmaier, Goetz wrote:
> Hi Coleen,
> Could you please also move
> AbstractInterpreter::can_be_compiled(methodHandle m)
> to above
> TemplateInterpreterGenerator::generate_math_entry(AbstractInterpreter::MethodKind kind)?
> I think these belong together.
Really? They're in different classes (hence the motivation for the
change) and generate_math_entry doesn't call can_be_compiled.
CompilationPolicy does but it calls it from
AbstractInterpreter::can_be_compiled() so I really can't move this
function into TemplateInterpreterGenerator. It doesn't make sense to me.
> We seem to have different BIND macros on ppc. The '__' is also in the
> macro. Could you please fix this small issue? It breaks the ppc build.
> diff -r 743aa331fc90 src/cpu/ppc/vm/templateInterpreterGenerator_ppc.cpp
> --- a/src/cpu/ppc/vm/templateInterpreterGenerator_ppc.cpp Tue Jan 05 07:47:21 2016 +0100
> +++ b/src/cpu/ppc/vm/templateInterpreterGenerator_ppc.cpp Tue Jan 05 08:06:12 2016 +0100
> @@ -416,7 +416,7 @@
> default: ShouldNotReachHere();
> - __ BIND(done);
> + BIND(done);
> __ blr();
> return entry;
> Besides this, the change looks good.
> Thanks and best regards,
> PS: is it possible to share your Copyright script?
>> -----Original Message-----
>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
>> Behalf Of Coleen Phillimore
>> Sent: Monday, January 04, 2016 11:43 PM
>> To: hotspot-dev developers <hotspot-dev at openjdk.java.net>
>> Subject: RFR (M) 8146410: Interpreter functions are declared and defined in
>> the wrong files
>> Summary: Moved functions to the correct files.
>> See bug for more details.
>> I basically did an hg mv templateInterpreter_<cpu>.cpp
>> abstractInterpreter_<cpu>.cpp and moved the interpreter_<cpu>.cpp
>> functions there.
>> Also moved generate_slow_signature_handler to
>> TemplateInterpreterGenerator/CppInterpreterGenerator because it's not
>> open webrev at http://cr.openjdk.java.net/~coleenp/8146410/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8146410
>> Tested with JPRT on Oracle supported platforms and built zero on linux
>> x86. Also fixed change that broke zero in stack_zero.inline.hpp. I
>> think this should work on PPC and AARCH64, but please let me know.
>> One question for AARCH64 platform in file:
More information about the hotspot-dev