RFR 8145628: hotspot metadata classes shouldn't use HeapWordSize or heap related macros like align_object_size

harold seigel harold.seigel at oracle.com
Wed Jan 27 20:57:35 UTC 2016

Hi Coleen,

The changes look good.

One comment, these two methods in globalDefinitions.hpp appear to be no-ops:

498 inline intptr_t align_metadata_size(intptr_t size) {
499 return align_size_up(size, 1);
500 }
502 inline intptr_t align_metadata_offset(intptr_t offset) {
503 return align_size_up(offset, 1);
504 }

Are the size and offset arguments already in words? If so, could you add 
a comment?

Thanks, Harold

On 1/27/2016 1:27 PM, Coleen Phillimore wrote:
> Summary: Use align_metadata_size, align_metadata_offset and 
> is_metadata_aligned for metadata rather
> than align_object_size, etc.  Use wordSize rather than HeapWordSize 
> for metadata.  Use align_ptr_up
> rather than align_pointer_up (all the related functions are ptr).
> Ran RBT quick tests on all platforms along with Chris's Plummers 
> change for 8143608, ran jtreg hotspot tests and nsk.sajdi.testlist 
> co-located tests because there are SA changes.   Reran subset of this 
> after merging.
> I have a script to update copyrights on commit. It's not a big change, 
> just mostly boring.  See the bug comments for more details about the 
> change.
> open webrev at http://cr.openjdk.java.net/~coleenp/8145628.01/
> bug link https://bugs.openjdk.java.net/browse/JDK-8145628
> thanks,
> Coleen

More information about the hotspot-dev mailing list