RFR: 8078112: Integrate Selection/Resolution test suite into jtreg tests

David Holmes david.holmes at oracle.com
Tue Mar 1 05:49:59 UTC 2016

Hi Dmitry,

On 29/02/2016 9:27 PM, Dmitry Dmitriev wrote:
> Hello,
> Please review this patch, which integrates the selection/resolution test
> suite into the JTreg test suite. This test suite was developed by  Eric
> Mccorkle(OpenJDK: emc). Thanks Eric for that!
> This test suite uses a template-based generation scheme to exercise all
> aspects of the updated selection/resolution test suite from JVMS 8.  It
> runs a very large number of tests, representing a very wide variety of
> cases.  Extensive javadoc comments are found throughout the test code
> which describe the suite's functioning in more detail.
> Also note that this suite as already undergone extensive review as part
> of the development process.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8078112
> webrev.00: http://cr.openjdk.java.net/~ddmitriev/8078112/webrev.00/
> <http://cr.openjdk.java.net/%7Eddmitriev/8078112/webrev.00/>
> Testing: Jprt, RBT(all platforms, product & fastdebug builds)

I hate to open this debate again but I see:

  @library /runtime/SelectionResolution/classes

but no instructions on how to build the library contents.

Do we really need to specify a timeout?

@run main/othervm/timeout=300

Will these tests now run as part of JPRT submissions? If so:
a) have they been tested on all platforms?
b) how long do they take to run?


> Thanks,
> Dmitry

More information about the hotspot-dev mailing list