RFR: 8151436: Leaner ArrayAllocator and BitMaps

Stefan Karlsson stefan.karlsson at oracle.com
Wed Mar 9 11:39:11 UTC 2016

Thanks, Thomas.


On 2016-03-08 12:10, Thomas Schatzl wrote:
> Hi Stefan,
> On Tue, 2016-03-08 at 11:33 +0100, Stefan Karlsson wrote:
>> Hi all,
>> Please review this patch to remove the state variables from
>> ArrayAllocator and make it an AllStatic class instead. The main
>> motivation for this patch is to cleanup the BitMaps data structure
>> and
>> make the instances smaller.
>> The patch builds on the fact that the current code invokes
>> AllocateHeap
>> with the default value AllocFailEnum:EXIT_OOM, and therefore never
>> returns NULL. This means that use_malloc will never be reset and the
>> allocation strategy used (malloc or mmap) can be determined by simply
>> looking at the size input parameter. Instead of changing the code to
>> use
>> AllocateHeap with AllocFailEnum::RETURN_NULL, I chose to keep the
>> current behavior so that we could cleanup and minimize the size of
>> our
>> BitMaps.
>> http://cr.openjdk.java.net/~stefank/8151436/webrev/
>> https://bugs.openjdk.java.net/browse/JDK-8151436
>    looks good.
> Thomas

More information about the hotspot-dev mailing list