RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

Tim Bell tim.bell at oracle.com
Sat Mar 12 21:11:38 UTC 2016


> When building hotspot with closed sources present and configuring with 
> --enable-openjdk-only, various closed parts are included in the build 
> anyway, at least on Windows. This needs to be fixed in preparation for 
> the new hotspot build for build output comparisons to be meaningful 
> between the old and new.
> The major culprit here, which applies to all platforms, is the trace 
> source generation. The base trace.xml uses XInclude to explicitly and 
> unconditionally include closed xml files if present. I'm fixing this 
> by introducing a closed version of trace.xml which includes the open 
> and closed parts, while the open trace.xml only includes the open parts.
> The rest of the changes are just for Windows, making sure the OPENJDK 
> variable is propagated into the nmake build and making all 
> conditionals on including closed source also check that variable.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8151653
> Webrev: 
> http://cr.openjdk.java.net/~erikj/8151653/webrev.hotspot.01/index.html

This looks good to me.


More information about the hotspot-dev mailing list