RFR(S): 8151707: Mark hotspot tests which ignore external VM flags

Christian Tornqvist christian.tornqvist at oracle.com
Thu Mar 17 15:42:11 UTC 2016

Hi Dima,

I don't think this is the right way to go, we need to stop with the flag rotation madness and this is another step in trying to preserve that. Tests need to explicitly define how they're supposed to run, this is not getting us any nearer that. I don't think we should make this change.


-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Dmitry Fazunenko
Sent: Thursday, March 17, 2016 10:51 AM
To: hotspot-dev at openjdk.java.net
Subject: RFR(S): 8151707: Mark hotspot tests which ignore external VM flags


Could you review a simple fix with introduces a new jtreg keyword: 
The purpose of this keyword is to mark those tests which ignore VM flags given outside (on the command line).
It will allow to not run such tests many times in different VM configurations as we do every night, but run only once.

Note: this fix will not affect execution, so the tests labeled as "noflags" will not be automatically filtered out in case of external VM flags are given. It will just allow to not execute such tests:
   # jtreg  -k:'!noflags' -vmflags:'-XX:+UseG1GC -Xint' test/

Note2: All the tests modified tests are manually reviewed to be sure that they indeed ignore external VM flags.



More information about the hotspot-dev mailing list