RFR: 8078112: Integrate Selection/Resolution test suite into jtreg tests
karen.kinnear at oracle.com
Thu Mar 24 15:58:35 UTC 2016
Looks good. Many thanks for adding the @modules.
> On Mar 24, 2016, at 11:01 AM, Dmitry Dmitriev <dmitry.dmitriev at oracle.com> wrote:
> Hi Christian,
> Can you please take a look into webrev.02. The only change - I added "@modules" to the tests.
> webrev.02: http://cr.openjdk.java.net/~ddmitriev/8078112/webrev.02/ <http://cr.openjdk.java.net/%7Eddmitriev/8078112/webrev.02/>
> webrev.02.vs.01: http://cr.openjdk.java.net/~ddmitriev/8078112/webrev.02.vs.01/ <http://cr.openjdk.java.net/%7Eddmitriev/8078112/webrev.02.vs.01/>
> Thank you,
> On 04.03.2016 20:12, Christian Tornqvist wrote:
>> Hi Dmitry,
>> This looks good, thanks for taking care of this.
>> -----Original Message-----
>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Dmitry Dmitriev
>> Sent: Tuesday, March 1, 2016 12:39 PM
>> To: David Holmes <david.holmes at oracle.com>; hotspot-dev at openjdk.java.net
>> Subject: Re: RFR: 8078112: Integrate Selection/Resolution test suite into jtreg tests
>> Hello David,
>> Thank you for the comments! I added build instructions to the tests.
>> I specify timeout because on fastdebug builds test needs more time.
>> Only two tests will be run as part of JPRT submissions - InvokeStaticSuccessTest and NoSuchMethodErrorTest.
>> InvokeStaticSuccessTest takes 1-3 seconds and NoSuchMethodErrorTest takes 2-9 seconds. Other tests are excluded from JPRT run.
>> Updated webrev.01:
>> Thank you,
>> On 01.03.2016 8:49, David Holmes wrote:
>>> Hi Dmitry,
>>> On 29/02/2016 9:27 PM, Dmitry Dmitriev wrote:
>>>> Please review this patch, which integrates the selection/resolution
>>>> test suite into the JTreg test suite. This test suite was developed
>>>> by Eric
>>>> Mccorkle(OpenJDK: emc). Thanks Eric for that!
>>>> This test suite uses a template-based generation scheme to exercise
>>>> all aspects of the updated selection/resolution test suite from JVMS
>>>> 8. It runs a very large number of tests, representing a very wide
>>>> variety of cases. Extensive javadoc comments are found throughout
>>>> the test code which describe the suite's functioning in more detail.
>>>> Also note that this suite as already undergone extensive review as
>>>> part of the development process.
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8078112
>>>> webrev.00: http://cr.openjdk.java.net/~ddmitriev/8078112/webrev.00/
>>>> Testing: Jprt, RBT(all platforms, product & fastdebug builds)
>>> I hate to open this debate again but I see:
>>> @library /runtime/SelectionResolution/classes
>>> but no instructions on how to build the library contents.
>>> Do we really need to specify a timeout?
>>> @run main/othervm/timeout=300
>>> Will these tests now run as part of JPRT submissions? If so:
>>> a) have they been tested on all platforms?
>>> b) how long do they take to run?
More information about the hotspot-dev