RFR (S) 8152698: Remove obsolete Unsafe.putOrdered{X} methods, usages, runtime and compiler support

Paul Sandoz paul.sandoz at oracle.com
Thu Mar 24 18:19:09 UTC 2016

> On 24 Mar 2016, at 19:09, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> On 03/24/2016 08:47 PM, Vladimir Kozlov wrote:
>> I think it is good cleanup. Some Hotspot tests changes are only new
>> empty line added - can you remove those changes?
> Thanks Vladimir!

+1 to the cleanup.

> Those tests are automatically generated: if I remove the whitespace, it
> will come back on next change. So I would rather leave that alone. (I
> remember Paul tried to fix JDK template gen with coalescing empty lines,
> not sure where did that go)

I updated the template generator to support an option not to generate empty lines for stuff that was “ifdef’ed” out, which is used in this case, but sometimes redundant newlines still leak through when the template is adjusted (i did not try too hard to avoid generating all redundant lines).

In this case some of the new newlines (e.g. at the end of the file) are a bit of a mystery to me. I would just leave as is and move on :-)


More information about the hotspot-dev mailing list