RFR(S): 8156760: VM crashes if -XX:-ReduceInitialCardMarks is set
vladimir.kozlov at oracle.com
Tue May 31 18:14:55 UTC 2016
Looks good to me.
On 5/31/16 4:27 AM, Tobias Hartmann wrote:
> Hi Thomas,
> On 31.05.2016 13:08, Thomas Schatzl wrote:
>> Hi Tobias,
>> On Mon, 2016-05-30 at 09:23 +0200, Tobias Hartmann wrote:
>>> all tests passed (link is attached to the bug). Is everyone fine with
>>> the latest webrev?
>> I would think it is good. I believe the necessary actions (card
>> marking) are taken with -XX:-ReduceInitialCardMarks from the comments,
>> in the places I would expect them. However my C2-fu is limited to
>> hacking together barriers, so I am honestly unable to verify that the
>> code in detail is correct.
> Thanks for looking at this again!
>> Somebody more knowledgable in C2 in general needs to look at this.
>> If you have time, copyrights may need to be fixed up. I do not need a
>> re-review for that.
> Right, I updated the copyright dates in-place.
More information about the hotspot-dev