RFR: 8166811: Missing memory fences between memory allocation and refinement
erik.helin at oracle.com
Fri Nov 18 13:00:33 UTC 2016
On 11/17/2016 10:06 PM, Kim Barrett wrote:
>> On Nov 17, 2016, at 12:28 PM, Erik Helin <erik.helin at oracle.com> wrote:
>> First of all, thanks for doing this tricky work. One initial comment:
>> 659 // Iterate over the objects overlapping the card designated by
>> 660 // card_ptr, applying cl to all references in the region. This
>> 661 // is a helper for G1RemSet::refine_card, and is tightly coupled
>> 662 // with it.
>> In the first sentence you mention the now removed argument card_ptr. Maybe just reword this to "Iterate over the objects covered by the memory region, applying cl to all references in the region”?
> You’re right, I missed updating the comment when the signature was changed.
> Changing to:
> // Iterate over the objects overlapping part of a card, applying cl
> // to all references in the region. This is a helper for
> // G1RemSet::refine_card, and is tightly coupled with it.
> which is still immediately followed by:
> // mr: the memory region covered by the card, trimmed to the
> // allocated space for this region. Must not be empty.
Ok, looks good. I think this patch is good to go now, thanks for taking
this on, appreciate it.
More information about the hotspot-dev