RFR for JDK-8165482 java in ldoms, with cpu-arch=generic has problems
martin.walsh at oracle.com
Fri Sep 23 13:34:28 UTC 2016
On 20/09/2016 08:42, Erik Joelsson wrote:
> On 2016-09-20 03:28, David Holmes wrote:
>> Hi Martin,
>> Build changes must be reviewed by the build team - now cc'd
> Thanks for forwarding David, I can't keep up with all the lists to find
> these unless posted to build-dev.
>> On 20/09/2016 12:16 AM, Martin Walsh wrote:
>>> Could I get a code review for the following bug:
>>> JDK-8165482 java in ldoms, with cpu-arch=generic has problems
>>> Webrev of the changes is available here:
>> What is the devinfo library? Is it part of the normal Solaris
>> installation, or does it need to be installed specifically? Is it
>> available in our official build toolkits?
> I did a bit of digging. It's part "system/libraries" so should be pretty
> standard. That package is in the devkit and I verified that
> libdevinfo.so is there too.
> Configure change looks fine. Just remember to also push the closed
> generated-configure.sh as David said.
>> Will checking the prom prior to using kstat change any of the values
>> we currently see? (other than the generic case being fixed of course).
It shouldn't, as SPARC64 seems to be reserved for Fujitsu SPARC
machines. However, to air on the side of caution I will investigate
further and follow-up shortly.
>> Also note you will need to generate and push the closed
>> generated-configure.sh file.
More information about the hotspot-dev