RFR(M): 8166560: [s390] Basic enablement of s390 port.
coleen.phillimore at oracle.com
Tue Sep 27 18:29:50 UTC 2016
Hi, I'm surprised there aren't more changes, probably because of the
#include work that was done by you previously. Which is great.
Can you describe this change? This makes all of the mutex's take a lot
of space, and some don't have very long names. Was this added to avoid
false sharing as the comment implies or to support longer names in monitors?
On 9/27/16 1:57 PM, Volker Simonis wrote:
> On Fri, Sep 23, 2016 at 8:11 AM, David Holmes <david.holmes at oracle.com> wrote:
>> Hi Goetz,
>> I see a change not related directly to S390 ie change from ARM to ARM32 in
> The change looks a little confusing because Goetz reordered the ifdef
> cascades alphabetically (which I think is good).
> Besides that, the only real change not related to s390 is indeed the
> change from ARM to ARM32 which happend two times in the file.
> @Goetz: have you done this intentionally?
>> It will be a while before I can go through this in any detail.
>> On 23/09/2016 3:52 PM, Lindenmaier, Goetz wrote:
>>> This change is part of the s390 port. It contains some basic adaptions
>>> needed for a full hotspot port for linux s390x.
>>> It defines the required macros, platform names and includes.
>>> The s390 port calles CodeCache::contains() in current_frame(), which is
>>> used in NMT. As NMT already collects stack traces before the CodeCache is
>>> initialized, contains() needs a check for this.
>>> Wherever a row of platforms are listed, I sorted them alphabetically.
>>> The jdk requires the file jvm.cfg.
>>> Please review. I please need a sponsor.
>>> Best regards,
More information about the hotspot-dev