RFR(M): 8166560: [s390] Basic enablement of s390 port.
goetz.lindenmaier at sap.com
Wed Sep 28 10:26:47 UTC 2016
here a new webrev for this change:
I reverted the major reorderings in macros.hpp and os_linux.cpp.
David asked me to do so, and I guess it makes reviewing more simple.
Also this fixes the issue spotted by David which actually was wrong.
The other renaming of ARM to ARM32 was correct, though, as
AARCH64 is defined in both ARM 64-bit ports, and is checked before.
So the existing case checking ARM is only reached if !LP64.
I documented this ...
Also I removed the change in mutex.hpp. Maybe we contribute
the full change this was part of, but independent of the s390 port.
I withdraw the part of the change to jdk introducing jvm.cfg. Volker wants to
do a separate change for this.
> -----Original Message-----
> From: Volker Simonis [mailto:volker.simonis at gmail.com]
> Sent: Dienstag, 27. September 2016 19:58
> To: David Holmes <david.holmes at oracle.com>
> Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-
> dev at openjdk.java.net; core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: Re: RFR(M): 8166560: [s390] Basic enablement of s390 port.
> On Fri, Sep 23, 2016 at 8:11 AM, David Holmes <david.holmes at oracle.com>
> > Hi Goetz,
> > I see a change not related directly to S390 ie change from ARM to ARM32 in
> > src/os/linux/vm/os_linux.cpp
> The change looks a little confusing because Goetz reordered the ifdef
> cascades alphabetically (which I think is good).
> Besides that, the only real change not related to s390 is indeed the
> change from ARM to ARM32 which happend two times in the file.
> @Goetz: have you done this intentionally?
> > It will be a while before I can go through this in any detail.
> > David
> > On 23/09/2016 3:52 PM, Lindenmaier, Goetz wrote:
> >> Hi,
> >> This change is part of the s390 port. It contains some basic adaptions
> >> needed for a full hotspot port for linux s390x.
> >> It defines the required macros, platform names and includes.
> >> The s390 port calles CodeCache::contains() in current_frame(), which is
> >> used in NMT. As NMT already collects stack traces before the CodeCache
> >> initialized, contains() needs a check for this.
> >> Wherever a row of platforms are listed, I sorted them alphabetically.
> >> The jdk requires the file jvm.cfg.
> >> Please review. I please need a sponsor.
> >> http://cr.openjdk.java.net/~goetz/wr16/8166560-
> >> http://cr.openjdk.java.net/~goetz/wr16/8166560-basic_s390/jdk.wr01/
> >> Best regards,
> >> Goetz.
More information about the hotspot-dev