RFR(M): 8166560: [s390] Basic enablement of s390 port.
martin.doerr at sap.com
Fri Sep 30 15:37:46 UTC 2016
I can contribute the change which Götz has mentioned.
Therefore, I have created a bug:
8166970: Adapt mutex padding according to DEFAULT_CACHE_LINE_SIZE
I will send out a RFR.
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Lindenmaier, Goetz
Sent: Mittwoch, 28. September 2016 11:53
To: Coleen Phillimore <coleen.phillimore at oracle.com>; hotspot-dev at openjdk.java.net
Subject: RE: RFR(M): 8166560: [s390] Basic enablement of s390 port.
yes, the #include change simplified this a lot. Also maintaining the patch
queue we have ...
We reordered the fields of mutex and aligned it to cache line boundaries.
This is the S390 part of this alignment change. S390 has 256B cache lines.
I'll remove it as the other parts of this change are missing anyways.
I’ll send a new webrev, soon.
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
> Behalf Of Coleen Phillimore
> Sent: Dienstag, 27. September 2016 20:30
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR(M): 8166560: [s390] Basic enablement of s390 port.
> Hi, I'm surprised there aren't more changes, probably because of the
> #include work that was done by you previously. Which is great.
> Can you describe this change? This makes all of the mutex's take a lot
> of space, and some don't have very long names. Was this added to avoid
> false sharing as the comment implies or to support longer names in
> On 9/27/16 1:57 PM, Volker Simonis wrote:
> > On Fri, Sep 23, 2016 at 8:11 AM, David Holmes <david.holmes at oracle.com>
> >> Hi Goetz,
> >> I see a change not related directly to S390 ie change from ARM to ARM32
> >> src/os/linux/vm/os_linux.cpp
> > The change looks a little confusing because Goetz reordered the ifdef
> > cascades alphabetically (which I think is good).
> > Besides that, the only real change not related to s390 is indeed the
> > change from ARM to ARM32 which happend two times in the file.
> > @Goetz: have you done this intentionally?
> >> It will be a while before I can go through this in any detail.
> >> David
> >> On 23/09/2016 3:52 PM, Lindenmaier, Goetz wrote:
> >>> Hi,
> >>> This change is part of the s390 port. It contains some basic adaptions
> >>> needed for a full hotspot port for linux s390x.
> >>> It defines the required macros, platform names and includes.
> >>> The s390 port calles CodeCache::contains() in current_frame(), which is
> >>> used in NMT. As NMT already collects stack traces before the CodeCache
> >>> initialized, contains() needs a check for this.
> >>> Wherever a row of platforms are listed, I sorted them alphabetically.
> >>> The jdk requires the file jvm.cfg.
> >>> Please review. I please need a sponsor.
> >>> http://cr.openjdk.java.net/~goetz/wr16/8166560-
> >>> http://cr.openjdk.java.net/~goetz/wr16/8166560-basic_s390/jdk.wr01/
> >>> Best regards,
> >>> Goetz.
More information about the hotspot-dev