RFR: 8178352: BitMap::get_next_zero_offset may give wrong result on Mac
stefan.karlsson at oracle.com
Mon Apr 10 16:48:03 UTC 2017
On 10/04/17 18:33, Kim Barrett wrote:
>> On Apr 10, 2017, at 12:18 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>> You did a couple of stylistic changes that now make the code inconsistent:
>>> I think these changes should be kept out of this patch.
>> Post-decrement in for loops still makes me twitch, even though it doesn’t matter
>> in this code base. But okay.
> Updated webrev:
To be consistent with the other code it in that file (res & 1) == 0
should be !(res & 1). Maybe create a small, trivial cleanup RFE to
change the following in the BitMap files: * !(res & 1) => (res & 1) == 0
* res = res >> 1 => res >>= 1 I'll promise to do a quick review ;) StefanK
More information about the hotspot-dev