RFR[XS] JDK-8178543 - Optimize Klass::is_shared()
ioi.lam at oracle.com
Thu Apr 13 17:41:03 UTC 2017
Hi Calvin & Coleen,
Thanks for the review. I will make the change as Coleen suggested and push.
On 4/13/17 8:15 PM, coleen.phillimore at oracle.com wrote:
> This looks good. Glad there was an access flag bit left.
> I'd make it #ifdef ASSERT instead. I don't think anyone's built
> optimized in a long time tho.
> On 4/13/17 5:30 AM, Ioi Lam wrote:
>> Hi, please review this small start-up enhancement:
>> We have a benchmark that shows Klass::is_shared() is called very
>> frequently during InstanceKlass::link_class_impl, and costs about 2%
>> of the start-up time.
>> The fix is simple -- instead of walking the list of CDS shared
>> regions, use a new bit in Klass::_access_flags
>> - Ioi
More information about the hotspot-dev